Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] don't assume the IP holder immediately reflects the new IP to share for a cilium-bgp-lb Service #229

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[fix] don't assume the IP holder immediately reflects the new IP to share for a cilium-bgp-lb Service #229

merged 1 commit into from
Aug 29, 2024

Conversation

AshleyDumaine
Copy link
Member

Addresses edge cases where the ip-holder does not immediately reflect the new IP address that was added to perform IP sharing

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.34%. Comparing base (a13fc1c) to head (7137f14).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   55.52%   55.34%   -0.19%     
==========================================
  Files          12       12              
  Lines        1882     1881       -1     
==========================================
- Hits         1045     1041       -4     
- Misses        694      696       +2     
- Partials      143      144       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshleyDumaine AshleyDumaine merged commit 708ee98 into main Aug 29, 2024
4 of 5 checks passed
@AshleyDumaine AshleyDumaine deleted the shared-ip-check-fix branch August 29, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljohnson92 eljohnson92 eljohnson92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshleyDumaine @eljohnson92